User talk:CalendulaAsteraceae/Archive 9

Bracing..

Can you on your technical list, look into converting {{brace2}} use inside tables into the equivalent {{brace3}} usages? You would also need to add {{ts|bracetable}} to the table header though. Some recent updates I did were of this nature. Brace3 also seems to a little more consistent in appearance. ShakespeareFan00 (talk) 19:52, 20 January 2024 (UTC)

{{ppoem}} with blank params..

Should be an easy fix. If there is no input it should give no output. And put all the affected items in a tracking category. ShakespeareFan00 (talk) 12:22, 29 January 2024 (UTC)

Module:Custom rule

In line with good design, it may be wise to move the actual formatting pairs to a /data module independent of the main logic? ShakespeareFan00 (talk) 08:32, 31 January 2024 (UTC)

Good idea; done. —CalendulaAsteraceae (talk • contribs) 08:35, 31 January 2024 (UTC)

A script that stopped working..

Hi. Can you take a look at - https://en.wikisource.org/wiki/User:Inductiveload/MiniPane.js , it stopped working for me recently, which suggests it needs updating to use the current OOUI API over jquery? Thanks. ShakespeareFan00 (talk) 10:53, 1 February 2024 (UTC)

The fact that you're aware of the OOUI API means you already know more about the topic than I do, I'm afraid. I've done a bit of work with JavaScript here and there, but nothing nearly this sophisticated. —CalendulaAsteraceae (talk • contribs) 05:53, 2 February 2024 (UTC)

WD author brokenness

Petey thinks that I can fix this Rapunzel. The wikidata is wikidata:Q60428719 and I am thinking it is probably that third translator. Three ways that it could not look so bad on the page. 1) You see if you can fix it easily (but it might be something in another module, depending on how similar your module is to the template); 2) I make a data page for the third translator; 3) I release the link from the module and type it out by hand. I numbered them in order of my preference, but I suspect it is not a quick or easy fix, so let me know how your feelings/mood sways on this.

Sorry to bother you.--RaboKarbakian (talk) 00:07, 3 February 2024 (UTC)

@RaboKarbakian: Thanks for catching this! It turned out to be a pretty simple fix to Module:WD version, although you will still need to make a Wikidata item for the third translator to have her name show up in the citation instead of "unknown value". —CalendulaAsteraceae (talk • contribs) 04:33, 3 February 2024 (UTC)

That was so quick! Thanks!--RaboKarbakian (talk) 12:48, 3 February 2024 (UTC)

WD Author broke.

Author:Cleveland_Abbe - broke on {{WD author|Q112346316}} ShakespeareFan00 (talk) 13:03, 4 February 2024 (UTC)

@ShakespeareFan00: Thanks for noticing; should be fixed now. —CalendulaAsteraceae (talk • contribs) 03:29, 5 February 2024 (UTC)

Lists module..

Module:List Can you make this into something I can use instead of the {{*!/s}} and {{*/s}} etc? ShakespeareFan00 (talk) 21:54, 5 February 2024 (UTC)

I'm a bit busy at the moment, but I'll keep that in mind in future/when I'm looking for new projects. —CalendulaAsteraceae (talk • contribs) 21:17, 6 February 2024 (UTC)

Template:Roman

I put back the older documentation, and the module doesn't behave as indications would suggest. Can you look into getting the module and documentation consistent again? ShakespeareFan00 (talk) 09:25, 8 February 2024 (UTC)

Done! —CalendulaAsteraceae (talk • contribs) 15:50, 8 February 2024 (UTC)

Thanks. If you could figure out how to re-add the lowercase (and usej) functionality at some later date it would be appreciated. ShakespeareFan00 (talk) 15:55, 8 February 2024 (UTC)

Template:optional style

Can you tweak the logic so that I can also use it generate a class="" line ( A common approach in MANY MANY templates now?

It would also eventually be nice to have some kind of Module:HTMLFactory, that I can use to reformulate certain templates like {{*!/s}} and {{*s/i}} in terms of a more generic : {{open|li|<classline>|{{optionalstyle|}}||{optional attribs|}} }}, and avoid using parser functions :)

Thanks. ShakespeareFan00 (talk) 14:06, 9 February 2024 (UTC)

{{HTML attribute}}: Hope this does what you want! —CalendulaAsteraceae (talk • contribs) 17:22, 9 February 2024 (UTC)

Urgently fix header

I'm getting this message on all subpages: Lua error in Module:Header at line 787: attempt to concatenate local 'sister' (a nil value).

Please correct with urgency. Beeswaxcandle (talk) 00:31, 11 February 2024 (UTC)

Hi, I'm so sorry about that and thanks for noticing! Fixed now; will adjust testing procedures to catch that kind of error. —CalendulaAsteraceae (talk • contribs) 00:35, 11 February 2024 (UTC)

Portal:P

It's Portal:Language and literature, with lowercase literature. Currently all links to this Portal are broken. --EncycloPetey (talk) 06:55, 11 February 2024 (UTC)

Thanks for catching that! I've fixed the link in Module:Library of Congress Classification/data. —CalendulaAsteraceae (talk • contribs) 06:57, 11 February 2024 (UTC)

Template:RunningHeader/2

Your changes to the back-end apparently broke this.

This styles here no-longer work Page:A_color_notation_(Munsell).djvu/44 properly. ShakespeareFan00 (talk) 08:25, 11 February 2024 (UTC)

@ShakespeareFan00: {{RunningHeader/core}} hasn't had a style parameter since November. What's not working? —CalendulaAsteraceae (talk • contribs) 09:04, 11 February 2024 (UTC)

When examining what was in the page, rh-1 and rh-2 class names were not being added, whereas running-header-1 and running-header-2 prefixs were, I was trying to migrate pages over to the new CSS class names. (For rh-3 and above rh-n generation is working. BTW and conversions are now mostly done.) ShakespeareFan00 (talk) 09:29, 11 February 2024 (UTC)

Thank you for working on that! —CalendulaAsteraceae (talk • contribs) 09:32, 11 February 2024 (UTC)

Specifically - {{rh/2}} generates (for an example)

<templatestyles src="RunningHeader/styles.css" /><div class="wst-running-header wst-running-header-2 "><div class="wst-running-header-cell">
36
</div><div class="wst-running-header-cell">
MIXTURE & BALANCE
</div></div>

The generation here should ideally, be putting in both the old and new names as for rh-3, rh-4 etc? ShakespeareFan00 (talk) 09:43, 11 February 2024 (UTC)

Yes. My plan for effecting that is to update current uses of {{rh}} with 1 or 2 parameters to use 3 parameters, then remove from Module:Running header the code that enforces a minimum of 3 cells, and then replace uses of {{rh/1}} and {{rh/2}} with {{rh}}. —CalendulaAsteraceae (talk • contribs) 09:46, 11 February 2024 (UTC)

Ah okay. Thanks. Then the current conversions of CSS class names is mostly complete apart from these edge cases.:) ShakespeareFan00 (talk) 09:48, 11 February 2024 (UTC)

Great, thank you! —CalendulaAsteraceae (talk • contribs) 09:50, 11 February 2024 (UTC)

In respect of some {{rh/1}} and single param {{rh}} instances - {{Leafsig}} (for "leaf signature" could be used in preference, with a careful editor to manually check pages to do conversions or removal (generally some contributor don't include printer/binding artefacts.) ShakespeareFan00 (talk) 10:33, 11 February 2024 (UTC)

The_Ocean_Hop

It's reporting a script error in the header , in relation to Module:Cast and crew, "Lua error in Module:Cast_and_crew at line 198: attempt to index field 'datavalue' (a nil value)." Looking for Wikidata that doesn't exist? ShakespeareFan00 (talk) 11:34, 11 February 2024 (UTC)

Thanks for catching that! Fixed. —CalendulaAsteraceae (talk • contribs) 23:43, 11 February 2024 (UTC)

Any good at math? I might need a convertor from XYZ and xyY color space to RGB at some point. ;) ShakespeareFan00 (talk) ShakespeareFan00 (talk) 23:49, 11 February 2024 (UTC)

I'm good at math, but color conversion scares me >.> —CalendulaAsteraceae (talk • contribs) 17:21, 12 February 2024 (UTC)

Running header : recto verso forms and CSS selector specificity.

Hi can you take a look at {{rh/lr}} and {{rh/1rv}} please, with the recent template/module and stylesheet migrations they appear to have stopped working as designed?

Alternatively it would be nice if these templates (and relevant Indexstyles) could be updated in line with your migration plans. ShakespeareFan00 (talk) 13:29, 12 February 2024 (UTC)

I think I've taken care of everything; thank you! It'll probably take a bit for all the existing uses of {{rh}} to be updated, so in the meantime I'll update the classes in {{RunningHeader/core}}. —CalendulaAsteraceae (talk • contribs) 17:20, 12 February 2024 (UTC)

Well, I also made some specfic tweaks in the templates myself. I'll withdraw and let you review. ShakespeareFan00 (talk) 17:21, 12 February 2024 (UTC)

Please check Template:RunningHeader/1rv/doc it is not displaying correctly. ShakespeareFan00 (talk) 17:24, 12 February 2024 (UTC)

Film song list and cast and crew

Hi! Do you happen to have a solution to the issue in the film song list module, where "Song" and "Performer" are on top of each other, with two blank columns beside them?

Also, I also noticed that in {{Cast and crew}}, the actor roles are no longer there for any of the characters. So for example, Steamboat Willie had "Walt Disney (as Mickey Mouse)" in his cast listing. SnowyCinema (talk) 21:57, 12 February 2024 (UTC)

I've fixed the song table formatting, and will work on the cast listing. —CalendulaAsteraceae (talk • contribs) 23:02, 12 February 2024 (UTC)

Thank you! SnowyCinema (talk) 23:18, 12 February 2024 (UTC)

And I'm done with the actor roles! —CalendulaAsteraceae (talk • contribs) 00:30, 13 February 2024 (UTC)

Header Glitch - Translation:Romance of the Three Kingdoms/Chapter 1

Is section now supposed to be a SPAN based field? ShakespeareFan00 (talk) 08:50, 14 February 2024 (UTC)

Yep; {{translation header}} now uses the same code base as {{header}}. —CalendulaAsteraceae (talk • contribs) 18:54, 14 February 2024 (UTC)

Header Glitch -Author:Richard Penn Smith

Your header changes exposed this. It now cannot cope with {{Wikipediaref}} inside a list item. ShakespeareFan00 (talk) 08:56, 14 February 2024 (UTC)

I think this is the same bug discussed above in #Header glitch:-. —CalendulaAsteraceae (talk • contribs) 20:59, 14 February 2024 (UTC)

Header broke - Author:James Grant

You do test these modfications beforehand I hope? ShakespeareFan00 (talk) 13:40, 14 February 2024 (UTC)

Line 443 looks to be a typo (knownCat vs. nownCat). MarkLSteadman (talk) 17:34, 14 February 2024 (UTC)

Thank you! —CalendulaAsteraceae (talk • contribs) 17:56, 14 February 2024 (UTC)

Translation:Romance_of_the_Three_Kingdoms/Chapter_5

Fixed with a <br> instead of a wrapped DIV, but ideally the header code should have a section_notes field to handle this situation and other summarisation subheadings? ShakespeareFan00 (talk) 21:04, 14 February 2024 (UTC)

I think I will make the section field div-based, but is there a reason to not just put that information in the notes field, or leave it out of the header and only include it in the body of the work? —CalendulaAsteraceae (talk • contribs) 21:35, 14 February 2024 (UTC)

Don't change anything yet though, It was ONLY present on this specfic use case, and I agree with you to some extent. Please open a wider discussion on the Scriptorum. ShakespeareFan00 (talk) 21:37, 14 February 2024 (UTC)

You raise a good point, though, that the people could put anything in the section parameter, and there's no indication in the documentation that it's span-based nor is there any particular reason for it to be. —CalendulaAsteraceae (talk • contribs) 05:11, 15 February 2024 (UTC)

Header glitch - Necromancer

Unterminated div from {{disambig}}. ShakespeareFan00 (talk) 08:02, 15 February 2024 (UTC)

I don't see anything in Special:LintErrors; could you link the tool you're using? —CalendulaAsteraceae (talk • contribs) 21:01, 15 February 2024 (UTC)

I fixed this at the Module: level. ShakespeareFan00 (talk) 21:12, 15 February 2024 (UTC)

The "may refer to" line is also gone. SnowyCinema (talk) 23:14, 15 February 2024 (UTC)

Template:RunningHeader/1rv .

Where was it causing a display issue?

https://en.wikisource.org/w/index.php?title=Template:RunningHeader/1rv&diff=prev&oldid=13873526

I checked the usage of it carefully , and did not see issues. ShakespeareFan00 (talk) 12:00, 15 February 2024 (UTC)

AFAIK, the template was supposed to produce centered running headers (with different recto/verso classes), not left/right running headers. Not important now that the template's been deleted! —CalendulaAsteraceae (talk • contribs) 20:58, 15 February 2024 (UTC)

Author:Abraham Fuller

Null value failure in Module code? ShakespeareFan00 (talk) 14:59, 15 February 2024 (UTC)

And PLEASE slow down in making major changes! ShakespeareFan00 (talk) 15:03, 15 February 2024 (UTC)

Personal Poems/Gone

Another nil value check missing.. I would suggest checking EVERY single value carefully. ShakespeareFan00 (talk) 21:28, 15 February 2024 (UTC)

Module talk:Author/testcases

If you are going to change something , make sure the test cases are still valid. ShakespeareFan00 (talk) 21:40, 15 February 2024 (UTC)

Hunger

Did you really mean for disambig pages to be considered undated works? ShakespeareFan00 (talk) 21:46, 15 February 2024 (UTC)