Module talk:PD

absolute mess

@CalendulaAsteraceae, @Xover, @Jan.Kamenicek:

What is happening that we are playing with our modules in the live space and one of our highest use templates. Please reset everything back to normal, and go and play in either with testcases and examples where we are not breaking things. This is not way that we do development. We should also be looking down these modules and templates so it isn't done again. — billinghurst sDrewth 03:43, 28 August 2022 (UTC)

@Billinghurst: It is a middling large brain surgery on them, and due to the sins of our fathers (well, or the limitations of older versions of MediaWiki with the resultant sloppy practices of previous technical contributors) there are insufficient test cases, clearly defined behaviour, etc. to be able to do that without some breakage. I am sure we can do even more to minimise the disruption, but some breakage is inevitable and just needs to be fixed on a case by case basis. So far there have been all of two actual reports of things that are broken (including yours on PD-US-no-notice) so I think we're still in pretty good shape.

But if you notice something broken, a note with a link to the page it was observed on and a brief description of what the symptoms were is the fastest path to getting it fixed. I observe that CalendulaAsteraceae is responding pretty quickly to any issues that show up, so most such issues shouldn't linger very long. Xover (talk) 07:11, 28 August 2022 (UTC)

xover. I saw at least three myself. We have made sandboxes and testcases when we have been through many of these changes, I have made many testcases and sandboxes myself over the years, as one makes then when you takes on such major changes ... build the testcases. Major changes should not be done on major data. Don't have the expectation that others will do them for you, it is unfortunately part of the business.

Plus where is the notice to the community of changes, what to expect and where to report such errors? Better than than having people trip across breakages unexpectantly. These are the standards as administrators and senior users we should be pushing. — billinghurst sDrewth 13:05, 28 August 2022 (UTC)

@Billinghurst: Apologies; this is something I should have known better about. Could I ask you or @Xover to revert the edits to {{PD-US-no-notice}} and {{PD-old-US}}? —CalendulaAsteraceae (talk • contribs) 05:08, 29 August 2022 (UTC)

@CalendulaAsteraceae: Done Xover (talk) 05:36, 29 August 2022 (UTC)

Where WD link to a person is in place, default add year of death to $1 in author: ns usage

At the moment, on author pages we utilise $1 parameter to manually add year of death to {{PD-US}}, as we can #invoke the year of death where it exists, I think that can be the next iteration for "human" authors we can look to just have that provided automatically, rather than manually. To check for that absence of the field at the moment has been a little harder since we transferred over from PD/US to PD-US, and in reality, if the data is there, then we don't need to do those compliance checks. — billinghurst sDrewth 21:51, 15 August 2023 (UTC)

I've added some code to do this to Module:PD/sandbox, adapted from Module:Author, and will test when it's a more sensible hour for me. —CalendulaAsteraceae (talk • contribs) 07:31, 24 August 2023 (UTC)

I've done the testing and everything looks good. It only works on authors whose death dates are known exactly to the year, but that does get you a lot of authors. —CalendulaAsteraceae (talk • contribs) 00:04, 27 August 2023 (UTC)

Pubyear used as deathyear when deathyear not specified

In The Philosophy and Theology of Averroes, the death year of the translator is not known. I put the license tag {{PD-US||1921}}, but this is rendering as {{PD-old}}. I have also tried {{PD-US|2=1921}} and {{PD-US|pubyear=1921}}. I can't figure out why this is, can you? —Beleg Tâl (talk) 15:19, 20 October 2023 (UTC)

@Beleg Tâl: This was a fun one! What was happening was that

1. The death year in {{PD-US}} was nil, so it was inferred from Wikidata.
2. d:Q19086826 didn't list Mohammad Jamil ur Rehman as the translator.
3. Module:License Wikidata actually didn't check for translators.
4. The module concluded that the latest and only relevant death date was that of Averroes in 1198.

I've fixed 2) and 3); everything should be working now. —CalendulaAsteraceae (talk • contribs) 03:40, 21 October 2023 (UTC)

Wow, great detective work :) and thank you! —Beleg Tâl (talk) 02:26, 22 October 2023 (UTC)